Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: Some transects have their origin and end point swapped #173

Closed
2320sharon opened this issue Aug 15, 2023 · 6 comments
Closed
Assignees
Labels
bug Something isn't working good first issue Good for newcomers V2 for version 2 of coastseg

Comments

@2320sharon
Copy link
Collaborator

Some transects have their origin and end point swapped.

Description:
Users have reported that certain transects, especially those around Fire Island, don't have their origin set as the landward point. Instead, the origin is set seaward. We need to devise a method to identify which transects have their origin in the sea and then swap the points for those specific transects. After rectifying the transects, it's crucial to update the Zenodo release.

Steps to Reproduce:

  1. Load the transects data for Fire Island.
  2. Save the transects to geojson with the save to file button
  3. Run the script get_transects_points.py located in coastseg/scripts with the transect geojson file generated in step 2
  4. Load origin_points.geojson generated by step 3 into geojson.io
  5. Observe that the origin points are located in the sea instead of landward

Expected Behavior:
All transects should have their origin as the landward point.

Actual Behavior:
Some transects have their origin set seaward.

Possible Solution:

  1. Develop an algorithm or script to identify transects with seaward origins.
  2. Swap the origin and end points for the identified transects.
  3. Update the dataset and release it on Zenodo.

Additional Information:

  • This issue might affect other regions as well, so a comprehensive check is recommended.
  • Ensure that the updated dataset is thoroughly tested before releasing on Zenodo.
@2320sharon 2320sharon added bug Something isn't working good first issue Good for newcomers labels Aug 15, 2023
@2320sharon
Copy link
Collaborator Author

2320sharon commented Aug 15, 2023

Here are some ideas we discussed in the Slack.

@2320sharon 2320sharon mentioned this issue Aug 16, 2023
10 tasks
@2320sharon 2320sharon added the V1 Version 1 of Coastseg label Aug 24, 2023
@2320sharon 2320sharon added V2 for version 2 of coastseg and removed V1 Version 1 of Coastseg labels Sep 7, 2023
@2320sharon
Copy link
Collaborator Author

2320sharon commented May 1, 2024

I've been working on analyzing our transects and fixing the transects that were in the wrong direction or were wrong.

The transects for Hawaii were in pretty bad shape and required quite a lot of cleaning. I'm posting them here before adding them to the next CoastSeg version.

Transects_grid_region_2_cleaned_version.zip

Remaining Tasks

  • region 0 barter island AK, whole dataset needs to be swapped

  • region 29 need to remove some transects

  • needs a lot swapped starts at cape charles

  • region 30 needs a LOT swapped

  • all around puerto rico

  • remove some around floria

@2320sharon
Copy link
Collaborator Author

Here is region 30 transects fixed

puerto_rico_fix_transects.zip
Transects_grid_region_30_swapped.zip

@2320sharon
Copy link
Collaborator Author

Alright region 29 was pretty easy
Just needed to swap one big group
region_29_fix_transects.zip
Transects_grid_region_29_swapped.zip

@2320sharon
Copy link
Collaborator Author

region 0 was the easiest I just had to run

python transects_swap_points.py  -i "C:\development\doodleverse\coastseg\CoastSeg\src\coastseg\transects\Transects_grid_region_0.geojson" -o "Transects_grid_region_0_swapped.geojson"

# bonus command to see the origin and end points
python get_transects_points.py  -i  "C:\development\doodleverse\coastseg\CoastSeg\scripts\Transects_grid_region_0_swapped.geojson"

Transects_grid_region_0_swapped.zip

@2320sharon
Copy link
Collaborator Author

These transects have been merged into main and all the transects are now facing the correct direction

2320sharon added a commit that referenced this issue May 2, 2024
…bad transects #173 #149 and add script to update transects
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers V2 for version 2 of coastseg
Projects
None yet
Development

No branches or pull requests

2 participants