Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs to remind users to "scroll left" when zoomed to full extent on the map #174

Closed
dbuscombe-usgs opened this issue Aug 16, 2023 · 10 comments
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@dbuscombe-usgs
Copy link
Member

Issue: when a user zooms out far enough, they are confronted with multiple versions of the world map. When a ROI is placed on a 'right-hand world', the pre-existing reference shorelines do not load on the map. They do, however, if a 'left-hand' world is used.

Possible solution 1: Can a limit be imposed on the level of zoom out, in order to prevent the 'multiple worlds' effect?

Fallback solution 1: Update the docs so users are advised to pan left, and use the left-hand version of the world map?

@dbuscombe-usgs dbuscombe-usgs added bug Something isn't working documentation Improvements or additions to documentation labels Aug 16, 2023
@2320sharon
Copy link
Collaborator

I was hoping that disabling the infinite map was as easy as setting world_copy_jump=False, but it seems this parameter is already False and changing it to True or False seems to do nothing...
https://ipyleaflet.readthedocs.io/en/latest/map_and_basemaps/map.html#:~:text=int%2C%20default%2015-,world_copy_jump,-%23

@2320sharon
Copy link
Collaborator

image
The goal to make it so that only one copy of the world is shown to the user. Not two copies

@2320sharon 2320sharon mentioned this issue Aug 16, 2023
10 tasks
@dbuscombe-usgs
Copy link
Member Author

I think we need
world_copy_jump = True

@dbuscombe-usgs
Copy link
Member Author

I think that will not prevent the multiple worlds, but perhaps it will allow our vector features to show up on any "right hand" world

@2320sharon
Copy link
Collaborator

I'm trying that out right now

@dbuscombe-usgs
Copy link
Member Author

Another idea would be to use fit_bounds using the extent of the world in the format [[south, west], [north, east]]

i.e. [[-90, -180], [90, 180]].

?

@2320sharon
Copy link
Collaborator

I tried the fit bounds idea earlier but its basically a glorified zoom to zone. doesn't actually limit the map

@2320sharon
Copy link
Collaborator

2320sharon commented Aug 16, 2023

The good news is the world_copy_jump = True worked
. I scrolled to each side of the world and it worked. I'm gong to test this a few times before I call this issue closed.

@dbuscombe-usgs
Copy link
Member Author

Great!

@2320sharon
Copy link
Collaborator

Looks like its working. I'm so glad that works.
I'll release this fix as part of 0.0.73dev4

2320sharon added a commit that referenced this issue Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants