Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Ability to Edit & Delete Extracted Shorelines in Coastsat Classifier Notebook #198

Closed
2320sharon opened this issue Oct 5, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request V2 for version 2 of coastseg

Comments

@2320sharon
Copy link
Collaborator

Feature Request: Ability to Edit & Delete Extracted Shorelines in Coastsat Classifier Notebook

Description:

The Coastsat Classifier Notebook needs a control that will enable users to manually edit the extracted shorelines. This would greatly improve the user experience by providing the flexibility to remove potential erroneous extractions directly from the map interface.

Proposed Functionality:

  1. Shoreline Selection:

    • Once an extracted shoreline is loaded onto the map, a user should be able to click on it.
    • Upon clicking, the selected shoreline should be highlighted (possibly with a color change or another distinguishable effect).
    • this feature would be similar to how ROIs and segments of the reference shoreline can be selected and deleted
  2. Delete Function:

    • Upon selection of a shoreline, a delete button/control should become active.
    • Clicking the delete button should:
      1. Remove the selected shoreline from the displayed map.
      2. Delete the corresponding data from the GeoJson file.
      3. Update the raw time series and the tidally corrected time series to reflect the removal.
  3. Batch Selection:

    • To make the process efficient, consider providing an option to select and delete multiple shorelines at once. This might need additional code and UI/UX considerations to ensure clarity.

Potential Challenges:

Deleting shorelines individually might be resource-intensive, so batch processing would be advantageous. However, batch operations might introduce complexity, both in terms of coding and UI/UX.

Impact:

Implementing this feature would provide users with a more refined tool, allowing them to ensure the accuracy and relevance of the extracted shoreline data. This in turn can lead to better analysis outcomes.


If anyone has suggestions or feedback regarding this proposed feature, please share!

@2320sharon 2320sharon added enhancement New feature or request V2 for version 2 of coastseg labels Oct 5, 2023
@2320sharon 2320sharon self-assigned this Oct 5, 2023
2320sharon added a commit that referenced this issue Oct 25, 2023
@2320sharon
Copy link
Collaborator Author

2320sharon commented Dec 15, 2023

  • get ROI IDs dropdown to have ROI IDs loaded when a session is loaded in
  • get ROI IDs dropdown to have ROI IDs loaded when a shorelines are extracted
  • get ROI IDs dropdown to delete all ROI IDs when the remove all button is clicked
  • get ROI IDs dropdown to delete all ROI IDs when the ROIs are removed
  • - [ ] get ROI IDs dropdown to delete all ROI IDs when the extracted shorelines are removed

2320sharon added a commit that referenced this issue Dec 21, 2023
@2320sharon
Copy link
Collaborator Author

This feature has been implemented in coastseg 1.1.24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request V2 for version 2 of coastseg
Projects
None yet
Development

No branches or pull requests

1 participant