Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Keep only the Reference Shorelines and Transects that intersect the ROIs #204

Closed
2320sharon opened this issue Nov 22, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@2320sharon
Copy link
Collaborator

If transects were loaded onto the map for the entire bounding box all those transects and shorelines are saved to the config. CoastSeg should keep only the transects and reference shorelines that intersect the ROIs.

This should reduce the size of the config file, reduce the number of transect shoreline intersections that need to be checked and the number of csv files generated.

@2320sharon 2320sharon added the enhancement New feature or request label Nov 22, 2023
@2320sharon 2320sharon self-assigned this Nov 22, 2023
@2320sharon 2320sharon changed the title Keep only the Reference Shorelines and Transects that intersect the ROIs Feature Request: Keep only the Reference Shorelines and Transects that intersect the ROIs Dec 6, 2023
@2320sharon
Copy link
Collaborator Author

I disagree with my previous statement here that only the transects in shorelines that intersect with the ROI should be saved the config files given that the config files are what link multiple ROIs together in a session. If we were to remove the shorelines and transects that didn't intersect then this might make it more difficult to load in sessions with multiple ROIs.

However when transects and extracted shorelines are intersected, then only the transects that intersect with the ROI should be kept, like what's performed in the extract shorelines method. This would improve performance, but it will take some planning to make sure that this is actually a feasible feature.

@2320sharon
Copy link
Collaborator Author

This behavior is already in place. Only transects that intersect with the ROI are kept when finding where shoreline points intersect transects. The config_gdf.geojson is meant to track all the features that were in that session not just the features for that particular ROI. If we choose to change this behavior then this issue can be reopened otherwise I will close it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant