add dynamodb describe table #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jacob-meacham if you could check this pull request, it will be very appreciated |
jacob-meacham
requested changes
Dec 18, 2017
src/index.js
Outdated
| * @see http://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/DynamoDB.html#describeTable-property | ||
| */ | ||
| async function getDynamoDbValue(key, awsParameters) { | ||
| winston.debug(`Resolving Kinesis stream with name ${key}`) |
There was a problem hiding this comment.
Typo in the logs: Kinesis -> Dynamo
geronimo-iia
commented
Dec 18, 2017
| * @see http://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/DynamoDB.html#describeTable-property | ||
| */ | ||
| async function getDynamoDbValue(key, awsParameters) { | ||
| winston.debug(`Resolving DynamoDB stream with name ${key}`) |
There was a problem hiding this comment.
@jacob-meacham I've doubted between dynamo or dynamoDB. Don't hesitate to revert to me if i should change it again.
jacob-meacham
approved these changes
Dec 19, 2017
|
Looks great, thanks for the change! |
|
@geronimo-iia - released as 1.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding dynamodb describetable method. It's usefull to find LatestStreamArn when ressource are declared outside 'serverless'.
Thanks for your work !