Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a way to enable/disable a component on an entity without removing it #12

Closed
2 tasks done
Doraku opened this issue Apr 28, 2018 · 2 comments
Closed
2 tasks done
Labels
enhancement New feature or request
Milestone

Comments

@Doraku
Copy link
Owner

Doraku commented Apr 28, 2018

Current target API:

public readonly struct Entity
{
    public bool IsEnabled<T>();

    public void Enable<T>();

    public void Disable<T>();
}
  • is it ok for disabled components to still appear in World.GetAllComponent? yes, Entity and component are different beast, same reason for disabled entities add a way to enable/disable an entity without removing it #13
  • is it ok for disabled component to still be serialized? yes, but they should still be disabled once deserialized
@Doraku Doraku added this to the 1.0 milestone Apr 28, 2018
@Doraku Doraku added enhancement New feature or request todo || !todo To do or not to do labels Aug 4, 2018
@Doraku Doraku removed this from the 1.0 milestone Aug 24, 2018
@Doraku Doraku mentioned this issue Jan 31, 2019
2 tasks
@Doraku Doraku added this to the 1.0 milestone Feb 9, 2019
@Doraku Doraku removed the todo || !todo To do or not to do label Feb 23, 2019
@Doraku
Copy link
Owner Author

Doraku commented Feb 23, 2019

c15cb6a

still need to handle serialization

@Doraku
Copy link
Owner Author

Doraku commented Feb 28, 2019

ce0c5a1 and done

@Doraku Doraku closed this as completed Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant