Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual Studio 2019 #2

Open
oxsd opened this issue Jun 24, 2019 · 3 comments
Open

Visual Studio 2019 #2

oxsd opened this issue Jun 24, 2019 · 3 comments

Comments

@oxsd
Copy link

oxsd commented Jun 24, 2019

Please update to work with Visual Studio 2019. Installation throws an error of a missing requirement: Microsoft.VisualStudio.Component.CoreEditor.

Thank you!!!!!

@michaelm7456
Copy link
Contributor

I've raised a Pull Request here with a change to allow the Extension to work with Visual Studio 2019.

Hope this helps!

@michaelm7456
Copy link
Contributor

The Pull request here which I think will resolve this has been merged into 'master'.

The Repo author has confirmed here that the changes have been merged.

I think all that remains is to have the latest iteration of this Repo published to the VS Gallery, although I've never done this step so I'm not sure what it involves.

@cskardon, is it possible to have the latest changes for this Extension published to the VS Gallery if the changes meet your approval and this isn't too much trouble?

And many thanks for the work involved in creating this Extension, much appreciated!

Cheers,

Michael

@cskardon
Copy link
Member

cskardon commented Aug 3, 2020

OK, I'm having trouble compiling it atm, which means I can't release it.
I've also gone over the changes I needed to do to go from 2015 to 2017 support - and I suspect (but as of yet don't know) a lot more will need to be changed. As it stands, on my list of 'todos' this is pretty low, but I will happily accept tested PRs that provably work in VS2019.

I'm sorry it's not an ideal response, honestly - atm I'd be looking to re-write it for 2019 I think anyhow. :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants