Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SA1625 does not take xml into account #1876

Closed
appel1 opened this issue Dec 1, 2015 · 2 comments
Closed

SA1625 does not take xml into account #1876

appel1 opened this issue Dec 1, 2015 · 2 comments
Assignees
Milestone

Comments

@appel1
Copy link

appel1 commented Dec 1, 2015

I don't think the following should trigger a violation.

/// <typeparam name="TFirst">The type of elements of <paramref name="first"/>.</typeparam>
/// <typeparam name="TSecond">The type of elements of <paramref name="second"/>.</typeparam>
@sharwell
Copy link
Member

sharwell commented Dec 1, 2015

I agree.

I wouldn't mind including this in 1.0 if we have to release another RC build, but I don't want to delay 1.0 stable for just this issue. I'm tentatively marking this for 1.0 so we don't accidentally overlook it.

/cc @pdelvo

@sharwell sharwell added this to the 1.0.0 milestone Dec 1, 2015
@martincostello
Copy link
Contributor

Another test case for this issue, except with <param> instead of <typeparam>:

/// <param name="dependencyOne">The optional <see cref="IDependencyOne"/> to use.</param>
/// <param name="dependencyTwo">The optional <see cref="IDependencyTwo"/> to use.</param>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants