Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessible readonly fields are reported twice #574

Closed
sharwell opened this issue Mar 28, 2015 · 2 comments · Fixed by #869
Closed

Accessible readonly fields are reported twice #574

sharwell opened this issue Mar 28, 2015 · 2 comments · Fixed by #869
Assignees
@pdelvo
Labels
enhancement fixed
Milestone
1.0.0 Alpha 7

Comments

@sharwell
Copy link
Member

Currently an externally-accessible readonly fields is reported as both SA1304 and SA1307. In this case, only SA1307 should be reported (see #557 for more information).

I'm marking this as enhancement instead of bug because the reference implementation of StyleCop reports both warnings for this case. We are only reporting one to simplify the presentation and code fix for users.
@pdelvo
Copy link
Member

pdelvo commented May 21, 2015

Im working on this

@vweijsters
Copy link
Contributor

@pdelvo Have a look at #861 and use the same mechanism when disabling part of SA1304 please.

@pdelvo pdelvo mentioned this issue May 22, 2015
Merged
@sharwell sharwell added this to the 1.0.0 Alpha 7 milestone May 23, 2015
@sharwell sharwell mentioned this issue Nov 16, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pdelvo pdelvo

Labels
enhancement fixed
Projects
None yet
Milestone
1.0.0 Alpha 7
Development

Successfully merging a pull request may close this issue.

Fix that SA1304 is reported for accessible fields pdelvo/StyleCopAnalyzers
3 participants
@sharwell @pdelvo @vweijsters