WPF0005 false positive

[brian-reichle]

I'm getting a WPF0005 false positive using WpfAnalyzers 2.4.0.

class Selectable : Control
{
    public static readonly DependencyProperty IsSelectedProperty = DependencyProperty.Register(
        nameof(IsSelected),
        typeof(bool),
        typeof(Selectable),
        new PropertyMetadata(new PropertyChangedCallback(OnIsSelectedChanged)));

    public bool IsSelected
    {
        get => (bool)GetValue(IsSelectedProperty);
        set => SetValue(IsSelectedProperty, value);
    }

    static void OnIsSelectedChanged(DependencyObject d, DependencyPropertyChangedEventArgs e)
    {
        var control = (Selectable)d;

        if ((bool)e.NewValue)
        {
            control.OnSelected();
        }
        else
        {
            control.OnUnseected();
        }
    }

    protected virtual void OnUnseected() // <-- WPF0005: Method 'OnUnselected' should be named 'OnIsSelectedChanged'
    {
    }

    protected virtual void OnSelected() // <-- WPF0005: Method 'OnSelected' should be named 'OnIsSelectedChanged'
    {
    }
}

Extracting 'if' block to another method seems to resolve the issue, so I'm not particularly concerned by it, just thought I should raise the issue in case you wanted to do something about it.

[JohanLarsson]

Ugh, I'm so terrible, thought I fixed this 🙂, thanks for reporting!
Much appreciated that you updated fast and provide fast and awesome feedback, nice to fix while some things are still in memory.

[JohanLarsson]

Wonder what the best fix is here, maybe no nag if more than one invocation?