Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Observation weights #192

Open
kamielkanfoudi opened this issue Feb 19, 2024 · 1 comment
Open

[Feature Request]: Observation weights #192

kamielkanfoudi opened this issue Feb 19, 2024 · 1 comment
Labels
enhancement extension of existing feature new feature new feature

Comments

@kamielkanfoudi
Copy link

Describe the feature you want to propose or implement

Hi! I am working on using the DML package to try and reproduce previous impact evaluation studies done with OLS to study causal inference. I have a dataset that includes observation weights and I can't seem to find a way to implement this as a parameter when fitting the PLIV model. Resampling the dataset has not seemed to work as the weights are within quite an unconventional range, [0.000004,0.05], and it becomes difficult to expand the data and keep the runtime at reasonable level. I'm not sure if I am missing something in the package where I can include these features. Thank you for your time!

Best,

Kami

Propose a possible solution or implementation

No response

Did you consider alternatives to the proposed solution. If yes, please describe

No response

Comments, context or references

No response

@kamielkanfoudi kamielkanfoudi added enhancement extension of existing feature new feature new feature labels Feb 19, 2024
@PhilippBach
Copy link
Member

Dear @kamielkanfoudi

thanks for your feature request. We agree that observation weights are very important for applying DoubleML on real data sets. We'll add this feature to the list of future extensions!

Unfortunately, I'm not yet aware of a paper that goes through the weighting adjustments in DoubleML. We'd have to read a bit more on this. The complication that arises in DoubleML as compared, for example, to linear regression is that the weights show up in two separate tasks: First - and this is what I guess you probably have in mind - they have to be accounted for during the estimation of the (causal) regression parameters. Second, they might play a role for the classification and regression ML learners.... I'm not sure, if ignoring them in the 2. step might create issues.

We'll investigate this in further detail and also discuss it with some colleagues who are more familiar with that literature, but adding it to the package might take a little bit of time.

Once more, thank you and best,

Philipp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement extension of existing feature new feature new feature
Projects
None yet
Development

No branches or pull requests

2 participants