Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with custom inventories created by other plugins #2

Open
blablubbabc opened this issue Feb 28, 2021 · 0 comments
Open

Comments

@blablubbabc
Copy link

A user of one of my plugins (Shopkeepers) reported this issue to me: Whenever he interacts with the editor inventory view of the Shopkeepers plugins (a custom chest-typed inventory with items acting as buttons), this plugins reorders the items of that inventory and thereby breaks it.

Custom inventories created by other plugins are probably affected by the same issue.

This plugin would probably have to somehow differentiate between regular chest inventories and custom inventories. There doesn't seem to be a definite solutions to this, but a first heuristic could be to check the inventory's InventoryHolder, and ignore the inventory if this holder is either null, or does not correspond to an actual chest block in the world.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant