Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests logging out exceptions #598

Closed
garethahealy opened this issue Apr 8, 2018 · 0 comments
Closed

Tests logging out exceptions #598

garethahealy opened this issue Apr 8, 2018 · 0 comments
Labels
enhancement

Comments

@garethahealy
Copy link
Collaborator

Its quite confusing when seeing the output of tests, which log exceptions but dont fail. It feels wrong.

Someone who doesnt know the code base will either investigate or ignore the message. In unit tests, we should always fail on exceptions but dont log them out.

Needs some thought.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@garethahealy