Typos and column headings

[zhanggeng218]

Hi DrGo! I'm testing the three simulated files. There are a few minor issues:

• The file extension is cvs instead of csv
• In the clinic file, there are two date columns. I use the first one as the visiting date. The second date column has the single value 1969-12-31
• There are no column names in the output csv files
• There are no major issues with using such simulated files in our macros. Specifically, I tested the conditions macro. Some minor preparations are needed to reshape the tables to the standard input.
• For the conditions macro, we also need the dpin dataset. I grabbed a mock dpin data created by Gurpreet to run the macro.

[DrGo]

Thanks Gene
This is very helpful
Yes 1969-12-31 is a placeholder
Monday, Can you paste the code you used to adapt for macro use and Gurpreet dpin generator?

[zhanggeng218]

In order not to mess up your repo with pull requestes, I uploaded the demo into this folder under our alima-design repo.

• There are three subfolders, config, data and source.
• The config folder contains the condition definition files.
• The data folder contains the three files generated by your program and the demo DPIN file.
• To run the demo, change the WORKING_ROOT parameter in the main.sas to the local path that contains the three folders.

[DrGo]

Thanks Geng,
I have moved the demo folder into this repo. I have also fixed the issues above and added dpin data.
can you pls rerun your code with the files generated from this version and check that we are getting the expected # of hospitalizations, etc?
I have documented the config.json a bit (see that file). Can you also add another chronic disease and see if you run into any issues?
Thanks,

[zhanggeng218]

• The files from the new version works.
• I added the chronic vascular disease to config.jason. The files were generated smoothly and also works with the demo. The conditions were identified as expected.
• The output from the macro are now put into csv files. Would you like me to push the new codes, results and config files to our alima-design repo, or create a pull request here?
• The current demo is a light weight version of or conditions macro. The heavy part comes from preparing datasets for identifying conditions, where the study period shall be specified and only records within the period are kept. Would you like to this in the demo?

[DrGo]

Thanks Geng,
Pls send a pull request. I think it would be great to add more realistic code into the demo. Two purposes:

• this could become our training module
• we could start moving into more systematic testing of our macros to ensure correction and minimize the risk of breaking and regression changes.

[zhanggeng218]

The systematic testing is would be a great idea. We also have many more tools when we are off RAS.