Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

./build-data.sh --force Suffers from Dependency Issue #27

Closed
theory opened this issue Oct 23, 2014 · 4 comments
Closed

./build-data.sh --force Suffers from Dependency Issue #27

theory opened this issue Oct 23, 2014 · 4 comments
Labels

Comments

@theory
Copy link
Contributor

theory commented Oct 23, 2014

./build-data.sh --force
rebuilding lib/Number/Phone/UK/Data.pm
rebuilding lib/Number/Phone/NANP/Data.pm
Can't locate Number/Phone/NANP/Data.pm in @INC (you may need to install the Number::Phone::NANP::Data module) (@INC contains: lib /usr/local/lib/perl5/site_perl/5.20.1/darwin-thread-multi-2level /usr/local/lib/perl5/site_perl/5.20.1 /usr/local/lib/perl5/5.20.1/darwin-thread-multi-2level /usr/local/lib/perl5/5.20.1 .) at lib/Number/Phone/Country.pm line 5.
BEGIN failed--compilation aborted at lib/Number/Phone/Country.pm line 5.
Compilation failed in require at build-data.nanp line 13.
BEGIN failed--compilation aborted at build-data.nanp line 13.
rebuilding lib/Number/Phone/StubCountry/*.pm
Can't locate Number/Phone/NANP/Data.pm in @INC (you may need to install the Number::Phone::NANP::Data module) (@INC contains: lib /usr/local/lib/perl5/site_perl/5.20.1/darwin-thread-multi-2level /usr/local/lib/perl5/site_perl/5.20.1 /usr/local/lib/perl5/5.20.1/darwin-thread-multi-2level /usr/local/lib/perl5/5.20.1 .) at build-data.stubs line 12.
BEGIN failed--compilation aborted at build-data.stubs line 12.

Not sure how Number::Phone::Country can be modified to make the dependency on Number::Phone::NANP::Data optional, at least while building. Is it necessary when building new data? If not, maybe it can just be mocked in build-data.nanp.

@DrHyde
Copy link
Owner

DrHyde commented Oct 23, 2014

Oops!

Breaking %NANP_areas out into a seperate module and using that in the script instead would do the trick I think.

@DrHyde DrHyde added the bug label Oct 23, 2014
@DrHyde
Copy link
Owner

DrHyde commented Mar 21, 2015

Fixed in 28604d

@DrHyde DrHyde closed this as completed Mar 21, 2015
@theory
Copy link
Contributor Author

theory commented Mar 21, 2015

Did you forget to push it?

@theory
Copy link
Contributor Author

theory commented Mar 21, 2015

Oh, sorry, there it is. Weird that it's not a link in your comment above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants