Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pumla footer not vanishing when setting to false in project cfg #31

Closed
DrMarkusVoss opened this issue Nov 24, 2021 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@DrMarkusVoss
Copy link
Owner

Describe the bug
see description

Desktop (please complete the following information):

  • pumla version 0.9.0

Additional context
Add any other context about the problem here.

@DrMarkusVoss DrMarkusVoss added the bug Something isn't working label Nov 24, 2021
@DrMarkusVoss
Copy link
Owner Author

That was due to the "global config" still being included from the global macros. That is not necessary anymore, as everyone should use the project-specific config. Otherwise, the variables will just not be set, which would lead to some "unspecified" behavior (default would be 0 = %false(), don't know what happens with the color for the tagged values). Therefore, there should also be a check implemented to at least warn you somehow (on diagram or during pumla update) about the fact that the current repo should be "setup right" with "pumla setupprj".

Maybe I can check one of the variables for its default value (color = 0) and then include the global config? have to check that, reminder for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant