COMMON: Move the PEResourceID constructors into the .cpp

And initialize the member variables in the init list, as suggested by cppcheck.
xoreos · Mar 19, 2013 · 10192ed · 10192ed
1 parent b7b2c3e
commit 10192ed
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/src/common/pe_exe.cpp b/src/common/pe_exe.cpp
@@ -32,6 +32,15 @@
 
 namespace Common {
 
+PEResourceID::PEResourceID() : _idType(kIDTypeNull) {
+}
+
+PEResourceID::PEResourceID(UString x) : _idType(kIDTypeString), _name(x) {
+}
+
+PEResourceID::PEResourceID(uint32 x) : _idType(kIDTypeNumerical), _id(x) {
+}
+
 PEResourceID &PEResourceID::operator=(UString string) {
 	_name = string;
 	_idType = kIDTypeString;

diff --git a/src/common/pe_exe.h b/src/common/pe_exe.h
@@ -42,9 +42,9 @@ class UString;
 
 class PEResourceID {
 public:
-	PEResourceID() { _idType = kIDTypeNull; }
-	PEResourceID(UString x) { _idType = kIDTypeString; _name = x; }
-	PEResourceID(uint32 x) { _idType = kIDTypeNumerical; _id = x; }
+	PEResourceID();
+	PEResourceID(UString x);
+	PEResourceID(uint32 x);
 
 	PEResourceID &operator=(UString string);
 	PEResourceID &operator=(uint32 x);