Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CraftTweaker(MT port for 1.8 +) recipe changing crash #362

Closed
the-creamster opened this issue Aug 16, 2016 · 7 comments
Closed

CraftTweaker(MT port for 1.8 +) recipe changing crash #362

the-creamster opened this issue Aug 16, 2016 · 7 comments

Comments

@the-creamster
Copy link

the-creamster commented Aug 16, 2016

I got the following crash when i used the command "/mt reload" upon attempting to edit a recipe. The reason behind changing the recipe is to fix/edit recipes given the configs/features of various mods in the modpack.

Minecraft version: 1.10.2
Minecraft Forge: build 2053
Draconic Evolution: 2.0.0.82

https://gist.github.com/the-creamster/246b1ddf2bef7aba1da9f92fa5d5733f

Edit:
The crash only ocurrs if the scripting lines are 'commented' out.

@the-creamster
Copy link
Author

Refer to the last comment in the linked github and make the decision for yourself.

@brandon3055
Copy link
Member

brandon3055 commented Aug 18, 2016

Looks like a crash related to my JEI integration. I found where the crash is occurring and came up with a fix but im not exactly sure why the crash was occurring so i cant be sure that my fix will work. Try this and let me know if its fixed.
Draconic-Evolution-1.10.2-2.0.0.84-universal.zip

Edit: dont forget to extract it (github dose not like jar's)

@the-creamster
Copy link
Author

the-creamster commented Aug 18, 2016

I will try it again anyway; even though the crash only occurred the initial once and not ever again when doing live testing with the CraftTweaker dev.

@the-creamster
Copy link
Author

the-creamster commented Aug 19, 2016

Ok, i got the exact crash again with the build you linked to me; https://gist.github.com/the-creamster/31e52bac5e7c727cfeb687b28e327e02
This time upon world reload after i had been in the world, joined successfully with all of the tweaked recipes commented out; un-commented the first one(can't remember if i reloaded the scripts then) and crash occurred again upon world reload with all tweaked recipes bar one commented out; that recipe being the one i put in the linked CraftTweaker issue which has now been closed and not going to get fixed CraftTweaker side.

Edit:
testing other scenarios to attempt to pinpoint it

@the-creamster
Copy link
Author

the-creamster commented Aug 19, 2016

Scenario 1:

  • all 3 tweaked recipes commented out upon pack & world load = no crash

Scenario 2:

  • scenario 1 is successful so i un-comment the first recipe and reload the scripts while in the world = no crash

Scenario 3:

  • scenario 2 is repeated for the other 2 recipes with a world reload after commenting out one, un-commenting another recipe and reloading scripts while in the world = no crash

@the-creamster
Copy link
Author

Another update:
I've tried just about every little combination i can think of and can't seem to replicate the crash with exact replication instructions. So you got any more ideas on how to pinpoint it if at all possible??

Also could you be referencing something in JEI which in it's latest 1.10.2 builds has internally changed and you haven't taken note of it?? just a thought

@brandon3055
Copy link
Member

Ok hopefully the latest build will finally fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants