Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch socketpair #572

Closed
wants to merge 6 commits into from

Conversation

yuyi2439
Copy link
Contributor

No description provided.

- 添加File端点
- 添加SocketPair trait并将Socket trait中的pair相关方法移动
- 添加对SockAddrUn的处理
- 将File端点换成Inode端点
- 尝试使用SocketInode进行socketpair(未成功)
@yuyi2439
Copy link
Contributor Author

目前会在kernel/src/net/socket/mod.rs:340处因downcast后unwarp而panic

@fslongjin
Copy link
Member

目前会在kernel/src/net/socket/mod.rs:340处因downcast后unwarp而panic

这个问题跟之前那个socketpair的pr的可能类似,我当时好像是
trait后面要加any和castfrom(如trait A:Send+Sync+Any+Castfrom

@yuyi2439 yuyi2439 marked this pull request as ready for review March 10, 2024 04:18
@yuyi2439
Copy link
Contributor Author

现在还需要修改SeqPacket的buffer类型,可以先把现在的修改review一遍

@@ -612,7 +612,7 @@ impl FileDescriptorVec {
if !FileDescriptorVec::validate_fd(fd) {
return None;
}
return self.fds[fd as usize].clone();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

对于长函数,请保留return 关键字,不要删掉。

@fslongjin
Copy link
Member

不要总是把代码在文件之间移动。这会导致git历史管理混乱。
上次你移动之后,我们其他人调bug,就因为找不到每行的历史,而难以定位bug。

请把他改回来。

@fslongjin fslongjin closed this Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants