Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose more should be internal API to become public #49

Open
KrayOristine opened this issue Sep 19, 2023 · 2 comments
Open

Expose more should be internal API to become public #49

KrayOristine opened this issue Sep 19, 2023 · 2 comments
Labels
Area-Mpq Related to project War3Net.IO.Mpq

Comments

@KrayOristine
Copy link

KrayOristine commented Sep 19, 2023

I'm currently hit the limitation of war3net on building my own w3x file. So, can you expose more of the internal API to public so that people can build their own w3x file without the need of a world editor? For now, i has created a fork with modification, maybe if i can made it work i would send you the pull request.

@KrayOristine KrayOristine changed the title Expose MPQ Stream API? Allow to create/construct MPQStream Sep 19, 2023
@KrayOristine KrayOristine changed the title Allow to create/construct MPQStream Expose more should be internal API to become public Sep 20, 2023
@Drake53 Drake53 added the Area-Mpq Related to project War3Net.IO.Mpq label Sep 24, 2023
@Drake53
Copy link
Owner

Drake53 commented Oct 1, 2023

I have added a new MpqStreamFactory class, containing all the logic that was previously in the MpqStream's constructor. This class has a public method that you can use: https://github.com/Drake53/War3Net/blob/vjass/src/War3Net.IO.Mpq/MpqStreamFactory.cs

You can take a look at the tests to see examples of how to use it: https://github.com/Drake53/War3Net/blob/vjass/tests/War3Net.IO.Mpq.Tests/MpqStreamUtilsTests.cs

@IS4Code
Copy link

IS4Code commented Dec 5, 2023

@Drake53 I would also like to request some additional accessible API to use. In my case, I would like to access the information about a particular entry's hash and locale, or, to be precise, a way to enumerate the hashes and locales and identify the files corresponding to them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Mpq Related to project War3Net.IO.Mpq
Projects
None yet
Development

No branches or pull requests

3 participants