Animating Background Color Crashing

[CharlesMassry]

When you use the method makeBackground with a basic default monotone colors that are created using the UIColor convenience methods, like UIColor.black, UIColor.white, UIColor.gray, etc., the app crashes because the way it finds the color components. In Swift 3 with iOS 10 these methods return a color with only two components, a darkness value and an alpha value. This does not cause an issue with colors like UIColor.red or UIColor(red: 0.0, blue: 0.0, green: 0.0, alpha: 1.0) however. I will be able to make a fix if you'd like.

[draveness]

That's great if you can open a PR 👍

[raulperez]

Hi.

This is still not fixed. I get a crash when trying to animate view's background color.

I have managed changing this code in DKKeyFrameAnimation:

    var valueArray: [Double] = []     ... to ...    var valueArray: [CGFloat] = []

and

     valueArray.append(value)  ... to ...  valueArray.append(CGFloat(value))

    fileprivate func valueArrayFor(startValue: CGFloat, endValue: CGFloat) -> NSArray {
        let startValue = Double(startValue)
        let endValue = Double(endValue)

        let steps: Int = Int(ceil(Double(kFPS) * self.duration)) + 2
        let increment = 1.0 / (Double)(steps - 1)
        var progress = 0.0
        var v = 0.0
        var value = 0.0

        var valueArray: [CGFloat] = []

        for _ in 0..<steps {
            v = self.functionBlock(self.duration * progress * 1000, 0, 1, self.duration * 1000);
            value = startValue + v * (endValue - startValue);

            valueArray.append(CGFloat(value))
            progress += increment
        }

        return valueArray as NSArray
    }

It could be possible to deploy a new version with a fix?

Thank you very much in advance.

[draveness]

@raulperez just released 2.0.1, but i don't know whether this could fix your bug or not.

[raulperez]

@draveness it doesn't. It continues crashing. If I apply the patch with the code I post over these comments it works again. But thank your for the help. Please, let me know when you have solved this issue. I will upgrade to the newest release again.