Skip to content
This repository has been archived by the owner on Jan 5, 2020. It is now read-only.

Dynamic Framework (& Carthage support) #5

Merged
merged 13 commits into from May 24, 2015
Merged

Dynamic Framework (& Carthage support) #5

merged 13 commits into from May 24, 2015

Conversation

mathiasnagler
Copy link
Contributor

Currently, DKChainableAnimationKit does not have a framework target. Instead the classes are in a project shared with an iOS sample app. This setup is prohibits the use of carthage as a depency manager. Also, imho the frameworks classes and the sample project should be separated.

I went ahead and separated everything into two projects. There now is one project for the actual framework and another one for the sample app. I also added a workspace containing both projects.

In addition I updated the .gitignore to also ignore OS X files like .DS_Store and fixes a spelling mistake (DKChainaleAnimationKit.swift --> DKChainableAnimationKit.swift).

@draveness
Copy link
Owner

Thx for your work, but when I fetch your branch and running the example project.

Error occurs.

e043f860-24f9-42b5-b3bb-86e479badff1

I tried to reset contents but not work

@mathiasnagler
Copy link
Contributor Author

Unfortunately, I am unable to reproduce the error. Could you please provide additional information? Did you try to run the example on the simulator or a real device? Which version of Xcode are you using?

For me, building and running the example succeeds for the simulator and also for my iPhone 6 running iOS 8.3.

It would also be helpful to see the actual error message. You should be able to find it in
~/Library/Logs/CoreSimulator/CoreSimulator.log
or
~/Library/Logs/CoreSimulator/[Device UDID]/system.log.

Sorry for the inconvenience.

@draveness
Copy link
Owner

When I run the iOS example on the simulator. It build successfully but there is nothing in the simulator but a black screen.

When I run the iOS example project on my iPhone6 Plus running iOS 8.3

42b952a1-e2dd-4b4a-9204-c9c71c8c173d

This is my xcode version

97e96697-57cd-4eed-a97f-521d8f37b23b

And this is the log when running on the simulator.

~/Library/Logs/CoreSimulator/CoreSimulator.log 

May 24 19:10:06 bogon CoreSimulatorService[1168] <Notice>: com.apple.CoreSimulator.CoreSimulatorService 117.15~1 starting.

Did you run the iOS Example project?

3a5aa8bf-297f-44bf-8752-f148e9da0b7c

@mathiasnagler
Copy link
Contributor Author

Thank you very much for the fast response!

The strange thing is, that you seem to see two instances of the Framework Scheme but no iOS Example Project Scheme.

It should look like this:
bildschirmfoto 2015-05-24 um 13 28 41

I went ahead and shared the iOS Example run Scheme. Maybe that fixes the problem? If not, I will download Xcode 6.3 tomorrow to see, if that causes the error. I am using Xcode 6.3.2.

@draveness
Copy link
Owner

I am really confused with this, Maybe I should merge it first and see whether this can work. I download your repo and checkout to feature/Framework branch everything works well

draveness added a commit that referenced this pull request May 24, 2015
Dynamic Framework (& Carthage support)
@draveness draveness merged commit 25f9c20 into draveness:master May 24, 2015
@draveness
Copy link
Owner

I have merged your PR, but after carthage update There is no framework in build folder.

@mathiasnagler
Copy link
Contributor Author

Thank you for merging. I will have a look at the issue as soon as I can find the time. I will get back to you soon.

@mathiasnagler mathiasnagler mentioned this pull request May 24, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants