Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all-day & multi-day support to /displaycal #122

Closed
smnc opened this issue Dec 7, 2021 · 4 comments · Fixed by #128
Closed

Add all-day & multi-day support to /displaycal #122

smnc opened this issue Dec 7, 2021 · 4 comments · Fixed by #128
Milestone

Comments

@smnc
Copy link
Collaborator

smnc commented Dec 7, 2021

Is your improvement request related to a problem? Please describe.
Currently /displaycal doesn't curently handle multi-day events well, only showing the first day. It also displays all-day events as running from "12:00am - 12:00am" (or "00:00 - 00:00" in 24-hour mode).

Describe the solution you'd like
The overview should display an event on each day it's happening.
It should also display all-day events as "All Day"

Describe alternatives you've considered
Creating a separate event for each day of a multi-day event.

Additional context
image

@NovaFox161 NovaFox161 added this to the v4.2.0 milestone Dec 8, 2021
@NovaFox161
Copy link
Member

Currently the way the code is, it grabs the next 15 events, then breaks them into groups of what day they start in, then builds the embed. This makes it easy to build the embed with events split up by day, but means that showing events on multiple days is impossible.

Tbh, I'm not really sure how I would (logically) get to doing this without some complicated code... But I see the issue with the current system.

@smnc
Copy link
Collaborator Author

smnc commented Dec 8, 2021

In the short run, how about the other half, listing all-day events as "All-Day" instead of "00:00 - 00:00"

@NovaFox161
Copy link
Member

I think I can do something like that.

Not sure how I would show it for multiple days tho unfortunately. Or rather, I could do it, but I'm not sure of a way to do it where my code would be readable and maintainable

@smnc
Copy link
Collaborator Author

smnc commented Dec 9, 2021

Noted. I'll handle things the manual way for now while we mull this over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants