Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generator dont check for query names #4

Closed
valentasm1 opened this issue Aug 3, 2021 · 3 comments
Closed

Generator dont check for query names #4

valentasm1 opened this issue Aug 3, 2021 · 3 comments

Comments

@valentasm1
Copy link

Lets say we have Action like this

GetThing(string language, [FromQuery(Name = "culture")] string? languageCulture)

It generates

GetThing(string language, string languageCulture = null);

which should be

GetThing(string language, [AliasAs("culture")]  string languageCulture = null);

Or

GetThing(string language, string culture= null);
@valentasm1
Copy link
Author

Workaround would be just name languageCulture > culture

@Dreamescaper
Copy link
Owner

Thanks for reporting!
I've published updated version.

@valentasm1
Copy link
Author

I wanted to complain why you closed this without fixing, since it looked to fast to fix it in that short time. After double check i realised that you fixed it. Super fast. Thank you .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants