New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Different Border Color? #6
Comments
Maybe you mean |
I had the same question. Fixed using these two attributes: app:mrb_progressBackgroundTint="#FFF" |
I've found that the border's thickness becomes smaller when the progress touched the star. I've used this style to test
The result is I can see that we don't have a true border that has the same thickness all the time. Also, I've found out that the mrb_indeterminateTint has not effect. |
Can you reproduce this with the sample app? Meanwhile what AndroidX AppCompat version are you using? |
At first the sample app is working as expected. When I put the white color, it showed the same result. mrb_secondaryProgressTint defines the thin border color. I've tried to migrate the sample app into Android X libraries, since I'm using it under Android X. I've found out that it is not an easy task, and give up after this error.
My original application (the above post) was using the below dependencies;
|
Thanks for the context, this reminded me of why it isn't working properly in your case. Basically the narrow border you saw is caused by antialiasing, and the fact that This is just how graphics works and cannot be "properly" fixed, and applies to either this library or the framework A workaround for this could be, replacing the progress drawable (in your case a white star) to be slightly bigger. This way it can cover the star on progress background entirely. To do so, include a copy of ( This is an entirely different issue than the original one, so please consider opening a new issue the next time :) This way we don't have to bother people who subscribed to the original issue. |
Is it possible to have a different border color? I see some styles for RatingBar that have many different colors and styles, but the border seems to be something very much bound to the Progress Drawable or the Indeterminate Drawable.
It would be great, for me, being able to control the border color at runtime.
The text was updated successfully, but these errors were encountered: