encoding command from dedicated maps

Dreat · Apr 23, 2017 · 41929f3 · 41929f3
1 parent 1d64594
commit 41929f3
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/zmq_ex/lib/zmq_ex.ex b/zmq_ex/lib/zmq_ex.ex
@@ -1,5 +1,4 @@
 defmodule ZmqEx do
-    use Bitwise
 
     def encode(%{flags: flags = %{type: _, long: :short, more: _}, size: size, body: <<body>>}) do
         <<encode_flags(flags), size :: size(8), body>>
@@ -14,6 +13,14 @@ defmodule ZmqEx do
         |> decode(rest)
     end
 
+    def encode_command(%{name: name, size: size, data: <<data :: binary>>}) do
+        case size do
+             0 -> %{flags: %{type: :command, long: :short, more: false}, size: 8, body:  name }
+             56 -> %{flags: %{type: :command, long: :long, more: false}, size: 64, body: name <> data}  
+             _ -> {:error}
+        end
+    end
+
     defp decode(flags = %{type: _, long: :short, more: _}, <<size :: size(8), body :: binary>>) do
         %{flags: flags, size: size, body: body}
     end

diff --git a/zmq_ex/test/zmq_ex_test.exs b/zmq_ex/test/zmq_ex_test.exs
@@ -42,4 +42,14 @@ defmodule ZmqExTest do
     result = ZmqEx.encode(%{flags: %{type: :command, long: :short, more: false}, size: 1, body: <<3>>})
     assert result == (<<4, 1, 3>>)
   end
+
+  test "encode short command" do
+    result = ZmqEx.encode_command(%{name: "command1", size: 0, data: << 0 >>})
+    assert result == %{flags: %{type: :command, long: :short, more: false}, size: 8, body: <<"command1">>}
+  end
+
+  test "encode long command" do
+    result = ZmqEx.encode_command(%{name: "command2", size: 56, data: "A command body"})
+    assert result == %{flags: %{type: :command, long: :long, more: false}, size: 64, body: <<"command2A command body">>}
+  end
 end