Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drip's docs link to their fork, NPM copy is from your repo (which has a different API) #2

Closed
wwalser opened this issue Apr 11, 2017 · 2 comments

Comments

@wwalser
Copy link
Contributor

wwalser commented Apr 11, 2017

Was just looking to use this and noticed that following links from Drip's documentation leads to https://github.com/DripEmail/drip-nodejs but using npm install gives a more up-to-date version from your repo.

This means that the documentation's API does not match the code that's been installed. For example, the subscribers api no longer takes both email and payload.

Edit: In practice, it's clear that there are several other issues with the library. If I put together well-written pull requests are you/the Drip team willing to accept them?

@samudary
Copy link
Contributor

Hey, thanks for pointing this out. I just merged the Drip fork with the main upstream from this repo. So all should be in sync.

I definitely agree that there are some opportunities for improvement in the library. This version is a first step towards ensuring that a Node package is available since we were getting quite a bit more demand for this. Will definitely be gradually making improvements.

Just reviewed your recent PR and that looks good and is now merged. We'd be happy to accept any contributions you may have.

Thanks!

@wwalser
Copy link
Contributor Author

wwalser commented Apr 13, 2017

Thanks @samudary 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants