Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: offer context menu on "commit..." window too, and remove it from places it doesn't make sense to show it #115

Closed
AndroidDeveloperLB opened this issue Apr 10, 2024 · 6 comments
Assignees
Labels
question Further information is requested

Comments

@AndroidDeveloperLB
Copy link

When I import multiple SVG files (into VectorDrawable) with various names , it's a bit annoying to find them manually and then choosing to use the addon.
Instead it could be nice to do it via the "commit..." window (the one that shows "Default changelist" as the root of the tree), as it shows the recently added files of the current branch.
Please offer the context menu there too, so that I could choose all files there and perform the optimization.

Also, please remove the context menu being offered from places that don't make sense , such as non-VectorDrawable files (java/kt files, for example), unless you see that the selected folder has them as children or "descendants"

@Drjacky Drjacky self-assigned this Apr 13, 2024
@Drjacky
Copy link
Owner

Drjacky commented May 19, 2024

It is already there:
Screenshot 2024-05-19 at 10 43 17

What I can do is add it to the "Commit Changes" Dialog:
Screenshot 2024-05-19 at 10 44 21

@Drjacky Drjacky added the question Further information is requested label May 19, 2024
@AndroidDeveloperLB
Copy link
Author

Yes, please add it there, and also please remove from places that don't make sense.

BTW, the plugin doesn't seem to be compatible anymore with latest canary versions. Please check it out.
I can't even see it anymore in the list (and in the marked).

@Drjacky
Copy link
Owner

Drjacky commented May 19, 2024

also please remove from places that don't make sense.

Yeah... this is an issue and difficult to fix. To have the item in the project pane, I need ProjectViewPopupMenu, and by having that, it doesn't matter if I disable the item in the right-click programmatically, it still displays it.
I need more time to fix this one... I'm not happy with that either :/

@Drjacky
Copy link
Owner

Drjacky commented May 19, 2024

Has been fixed in 3.5.5

@Drjacky Drjacky closed this as completed May 19, 2024
@AndroidDeveloperLB
Copy link
Author

I can't find it on the marketplace anymore:

image

Sure it was published?

@Drjacky
Copy link
Owner

Drjacky commented May 20, 2024

No, not yet. usually it takes 2 working days to be approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants