Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getter/Setter functions. #45

Merged
merged 1 commit into from Feb 17, 2016
Merged

Conversation

bhaskarmelkani
Copy link
Contributor

No description provided.

@@ -17,6 +17,7 @@ snippet examples for your day to day workflow. Contributions are welcome!
- [Maps](#maps)
- [WeakMaps](#weakmaps)
- [Promises](#promises)
- [Getter/Setter functions](#getter-and-setter-functions)

## var versus let / const

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not get it ?

@DrkSephy
Copy link
Owner

I'm still thinking about adding this in or not, as it doesn't seem to be a high priority feature. Moreover, the code examples provided will need to be formatted accordingly to the other examples in the readme (such as leading space before an opening {). Does anyone else have some feedback on whether or not these features should be included?

@bhaskarmelkani
Copy link
Contributor Author

Fixed formatting.

@DrkSephy
Copy link
Owner

Thank you for updating your PR, could you please rebase and resolve any merge conflicts on your end so that I can merge this in? Thanks!

@bhaskarmelkani
Copy link
Contributor Author

Done. Thanks

@DrkSephy
Copy link
Owner

Thanks! 👍

DrkSephy added a commit that referenced this pull request Feb 17, 2016
@DrkSephy DrkSephy merged commit 5f8f338 into DrkSephy:master Feb 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants