Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Welcome talk talk" is shown in Toolbar #336

Closed
YusukeIwaki opened this issue Feb 14, 2017 · 4 comments
Closed

"Welcome talk talk" is shown in Toolbar #336

YusukeIwaki opened this issue Feb 14, 2017 · 4 comments
Labels
Milestone

Comments

@YusukeIwaki
Copy link
Contributor

Overview (Required)

Toolbar shows thw word "talk" twice unexpectedly, during collapsing.

I don't know if this bug is caused by the bug of support libs or by some kind of implementation 馃槄

Actually this bug is really trivial, and no need to fix soon. However it would be better for us to share the issue and the workaround (if it exists). :)

Screenshot

@konifar
Copy link
Contributor

konifar commented Feb 14, 2017

馃憖

@konifar konifar added the bug label Feb 14, 2017
@konifar
Copy link
Contributor

konifar commented Feb 14, 2017

Thanks for report!
Actually we use multiline-collapsingtoolbar which extends support lib CollapsingToolbar to show multiline text.

This seems the library's spec, not bug 馃 But I guess black text is wrong.

@hironytic
Copy link
Contributor

I think this issue is related.

We can avoid this problem by simply deleting the shadow in SessionDetailExpandedToolbarTitle style, but the appearance becomes worse. 馃槦

@konifar
Copy link
Contributor

konifar commented Feb 17, 2017

@hironytic Thanks!
I guess it might be better to remove shadow and put black alpha color on the background image 馃挱

@konifar konifar closed this as completed Feb 17, 2017
@konifar konifar modified the milestone: 1.0.0 Mar 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants