Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep scroll position when back from session detail #33

Closed
takahirom opened this issue Nov 24, 2018 · 5 comments · Fixed by #303
Closed

Keep scroll position when back from session detail #33

takahirom opened this issue Nov 24, 2018 · 5 comments · Fixed by #303
Labels
assigned bug Something isn't working help wanted Extra attention is needed high priority welcome contribute
Milestone
0.1.0(〜01/20)

Comments

@takahirom
Copy link
Member

Overview

When back button press in session detail, scroll position will become top.
Because of BottomSheetDaySessionsFragment and BottomSheetFavoriteSessionsFragment instances are recreated.
If you know how to fix this, Please help me 🆘
@takahirom takahirom added bug Something isn't working help wanted Extra attention is needed labels Nov 24, 2018
@takahirom takahirom added this to the 0.1.0(〜01/20) milestone Jan 2, 2019
@takahirom takahirom pinned this issue Jan 6, 2019
@akihiro-ota-LITALICO
Copy link
Contributor

I think I will challenge 🙋‍♂️
After checking the operation, it seems that savedInstanceState is null at the screen transition. When you rotate the screen, savedInstanceState exists.
I do not have confidence 😇

@akihiro-ota-LITALICO
Copy link
Contributor

I thought, this seems to be a normal movement...

@takahirom
Copy link
Member Author

takahirom commented Jan 9, 2019 •
edited

If you can do it, Please 🙏
Should I assign you?

@akihiro-ota-LITALICO
Copy link
Contributor

I'll do it 🙋‍♂️

Should I assign you?
yes

@takahirom
Copy link
Member Author

Thanks 👍 Assigned

@akihiro-ota-LITALICO akihiro-ota-LITALICO mentioned this issue Jan 9, 2019
Merged
@takahirom takahirom unpinned this issue Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
assigned bug Something isn't working help wanted Extra attention is needed high priority welcome contribute
Projects
None yet
Milestone
0.1.0(〜01/20)
Development

Successfully merging a pull request may close this issue.

Suppress Fragment replacement akihiro-ota-LITALICO/conference-app-2019
2 participants
@takahirom @akihiro-ota-LITALICO