Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement about droidkaigi screen without design #40

Closed
takahirom opened this issue Nov 4, 2019 · 15 comments · Fixed by #670
Closed

Implement about droidkaigi screen without design #40

takahirom opened this issue Nov 4, 2019 · 15 comments · Fixed by #670

Comments

@takahirom
Copy link
Member

Overview (Required)

Title says everything.

Links

@takahirom takahirom added this to To do in 2020 Nov 4, 2019
@FujiKinaga FujiKinaga self-assigned this Nov 19, 2019
@FujiKinaga FujiKinaga removed their assignment Jan 11, 2020
@TaigaNatto
Copy link
Contributor

🙋‍♂️
i want to try this issue

What is the goal specifically on this issue ?

@takahirom
Copy link
Member Author

takahirom commented Jan 16, 2020

Thanks for your interest in this issue. 🤖
Not ready to address this issue. The design is likely to change a little from last year, so it seems unlikely that we can do so much.
You can assign and keep this issue, or work on other issues.

@TaigaNatto
Copy link
Contributor

Thanks for reply

ok,I'll try other isuue.
May I retry this issue when ready on design ?

@takahirom
Copy link
Member Author

You can assign multiple issues. How about it?

@takahirom
Copy link
Member Author

Now we can access the Design!!

@TaigaNatto
Copy link
Contributor

@takahirom
really!? i want to try this issue !

@FujiKinaga
Copy link
Contributor

@TaigaNatto
Of course!!
Assigned👍

@TaigaNatto
Copy link
Contributor

How much to implement on this issue ?

Should I wait for #41 to complete?

@takahirom
Copy link
Member Author

Thanks! I was thinking about doing this issue first.🙏

@TaigaNatto
Copy link
Contributor

Thank you ! I try it early !

@takahirom
Copy link
Member Author

@TaigaNatto Please let me know if you have any questions 🙏

@TaigaNatto
Copy link
Contributor

@takahirom
Thank you.
It feels good for this issue.

I just have question.

  • I'm trying to implement RecyclerView, can I just look at the existing implementation?
  • How much should I implement?

@takahirom
Copy link
Member Author

@TaigaNatto

I'm trying to implement RecyclerView, can I just look at the existing implementation?

Sorry. I don't understand. "look at the existing implementation" means using existing Groupie Item?? I think It is better to make it. 🙏

How much should I implement?

For now, All you need to do is create an item for Groupie and just show the string.
It's okay to implement the design, but I'm already running out of time so I want to get it early. 🙇

@TaigaNatto
Copy link
Contributor

@takahirom
I just did it ! Sorry for being late.

I have some questions.

  • Should Top Image prepare image data for each dpi?
  • Is there an implementation to get the version code of the app?

@takahirom
Copy link
Member Author

Should Top Image prepare image data for each dpi?

Now you can use empty image 👍

Is there an implementation to get the version code of the app?

It is ok to empty for now 👍

2020 automation moved this from To do to Done Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2020
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants