Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement "Staff" screen without design #19

Closed
takahirom opened this issue Feb 11, 2021 · 6 comments · Fixed by #294
Closed

Implement "Staff" screen without design #19

takahirom opened this issue Feb 11, 2021 · 6 comments · Fixed by #294
Assignees

Comments

@takahirom
Copy link
Member

takahirom commented Feb 11, 2021

Blocked by #18

Overview (Required)

Since we need to display the information, we need to create classes for ViewModel, Repository, and API for that.
Please refer to the existing implementation and implement it.
This time there is no need for DB cache.
The API documentation can be found below.

Links

https://droidkaigi.stoplight.io/docs/ssot-api/openapi/reference/external.v1.yaml

@tfandkusu
Copy link
Contributor

🙋

@tomoya0x00
Copy link
Contributor

Thanks! Assigned 👍

@tfandkusu
Copy link
Contributor

I have question about API.
I understood this issue needs API server implementation to get staff list and this document describes its endpoint.
But the endpoint https://ssot-api-staging.an.r.appspot.com/staff responds 404 error.
Does I need to wait its API server implementation ?

@tfandkusu
Copy link
Contributor

On second thought, ViewModel and its test don't need the API implementation.
I'll proceed with this issue.

@takahirom
Copy link
Member Author

I'm sorry, I think it's probably not implemented yet. Is it possible to create a fake api response and proceed with the implementation? 🙇

@tfandkusu
Copy link
Contributor

Thanks for the reply. I will create a fake API response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants