Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] French Settings Menu #66

Closed
1 task done
Npa972 opened this issue Dec 20, 2022 · 34 comments · Fixed by #94
Closed
1 task done

[Bug Report] French Settings Menu #66

Npa972 opened this issue Dec 20, 2022 · 34 comments · Fixed by #94
Assignees
Labels
Good first issue Good for newcomers Look & Feel The look and feel of the application Type: Bug Report Something isn't working

Comments

@Npa972
Copy link

Npa972 commented Dec 20, 2022

  • I have searched existing issues for this bug.

Bug description

Not really a bug because everything is working but french gestures setting is messy

Steps to reproduce

  1. set language french
    mLauncher in french
    (or system for me)
  2. reopen setting and scroll down to gestures
  3. ...
  4. ...

Environment information

  • mLauncher version: 0.3.5
  • Device name: xiaomi redmi 9C
  • Android version: 11
  • Other information:

Additional context (that might help us to solve your problem)

  • Screenshots or other context
@Npa972 Npa972 added the Type: Bug Report Something isn't working label Dec 20, 2022
@HeCodes2Much HeCodes2Much changed the title [Bug Report] [Bug Report] French Settings Menu Dec 20, 2022
@HeCodes2Much
Copy link
Contributor

Cheers I'll look into it after work.

Please remember to give reports titles in the future :)

@HeCodes2Much HeCodes2Much added Good first issue Good for newcomers Look & Feel The look and feel of the application labels Dec 20, 2022
@HeCodes2Much
Copy link
Contributor

@Npa972 I think I may have found the issue I think text size matters I'm going to look into this a bit and see if I can change the text so it has a limit of how much space it can take up

@HeCodes2Much
Copy link
Contributor

@Npa972 if you have the time could you make sure that the translation for french is correct at value-fr

@Npa972
Copy link
Author

Npa972 commented Dec 21, 2022

line 10 : À l'arrêt = Non
11 : Sur = Oui
12 = Le noir = Noir
18 : La gauche = Gauche
19 : Droit = Droite
44 : D'accord = OK
47 : Clavier d'affichage automatique = Affichage automatique du clavier
54: Étendre la zone cliquable sur les applications domestiques = Étendre la zone cliquable pour les applications de l'écran d'accueil
60 : Mode thème = Thème
63 : Lumière = Clair
68 : Copie = Copier
69 : proche = Fermer
77 : Spectacle = Montrer
83 : Handicapé = Désactivé
87 : Écran verrouillé = Verrouiller l'écran
89 : Spectacles récents = Montrer les applications récentes or Applications récentes

I have a doubt for line 64

@HeCodes2Much
Copy link
Contributor

Are you able to change it in the file then upload it here it make it a bit easier? Or just copy and paste the file within code brackets :)

@Npa972
Copy link
Author

Npa972 commented Dec 21, 2022

Tell me if it's ok
French mLauncher.odt

@HeCodes2Much
Copy link
Contributor

ya that is fine but why .odt for a .xml file :) i cant even read that file it opens up as a zip file had to use groupdocs to get the code :) i take it you don't use notepad instead you used word :)

@Npa972
Copy link
Author

Npa972 commented Dec 21, 2022

I tried with mousepad but we cannot join .txt
Same problem with .xml

@HeCodes2Much
Copy link
Contributor

thats wierd mousepad works for me just fine to edit code but i use vscode myself or some time neovim :)

@Npa972
Copy link
Author

Npa972 commented Dec 21, 2022

French mLauncher.txt
I had to rename with .txt and it's OK.
But .xml is not accepted.
image

@HeCodes2Much
Copy link
Contributor

cheers fixed in #83

@Npa972
Copy link
Author

Npa972 commented Dec 21, 2022

Thank's you !

@Npa972
Copy link
Author

Npa972 commented Dec 22, 2022

image
The problem with french settings menu is still there with 3.6.
It is not a problem for me because i keep english setting.

@HeCodes2Much
Copy link
Contributor

HeCodes2Much commented Dec 22, 2022

ya i'm looking into it now

how do you say show app list in french?

@Npa972
Copy link
Author

Npa972 commented Dec 22, 2022

The problem is that french language is not compact at all compared to english

@Npa972
Copy link
Author

Npa972 commented Dec 22, 2022

ya i'm looking into it now

how do you say show app list in french?

Afficher la liste des applications

@HeCodes2Much
Copy link
Contributor

The problem is that french language is not compact at all compared to english

ya if i was to change that 1 to just be Des applications it fixes it

@HeCodes2Much
Copy link
Contributor

ya i'm looking into it now
how do you say show app list in french?

Afficher la liste des applications

How is this?
Screenshot_20221222_145405

@Npa972
Copy link
Author

Npa972 commented Dec 22, 2022

"Ouvrir le lien"
It would be shorter with just "Ouvrir"
"Montrer application liste"
"Montrer liste des applications" would be better.

@HeCodes2Much HeCodes2Much linked a pull request Dec 22, 2022 that will close this issue
4 tasks
@HeCodes2Much
Copy link
Contributor

@Npa972 can you confirm this with the newest build?

image

@Npa972
Copy link
Author

Npa972 commented Dec 23, 2022

Non i don't confirm with newest build.
image
An it was really difficult to authorize mL to access accessibility function (to see the notifications). Restart phone, set again accessibility...

@HeCodes2Much
Copy link
Contributor

ya the spacing could be better?

image

also what do you mean by difficult to authorize all you do is swipe down and then it will go to the the settings to do it?

@HeCodes2Much
Copy link
Contributor

HeCodes2Much commented Dec 23, 2022

i made Open not be hard coded by doing

currentSelectionName = if (currentAction == Constants.Action.OpenApp) stringResource(R.string.open) + " $appLabel" else currentAction.string(),

maybe have the setting underneath like the summary? idk how we can best do this for languages that use long words for words that are 3 letters in english :)

@Npa972
Copy link
Author

Npa972 commented Dec 23, 2022

ya the spacing could be better?

image

also what do you mean by difficult to authorize all you do is swipe down and then it will go to the the settings to do it?

Yes i swipe dow an do the setting but then swipe down do not work at all. Going back to accessibility setting and had a message "this fonction do not work". Unset and reset authorization, restart phone, reset accessibility... same problem... But now it's working. I don't know why. Why do you link "swipe down for notifications" to accessibility ?

@HeCodes2Much HeCodes2Much reopened this Dec 23, 2022
@DroidWorksStudio DroidWorksStudio deleted a comment from github-actions bot Dec 23, 2022
@HeCodes2Much
Copy link
Contributor

HeCodes2Much commented Dec 23, 2022

Notifications and Recent both require accessibility settings to be enabled sadly that's why they both ask for it if you set them

this is different from android default swipe from the top that has it cus its a base feature already so its hard coded to have access to accessibility features

@Npa972
Copy link
Author

Npa972 commented Dec 23, 2022

Notifications and Recent both require accessibility settings to be enabled sadly that's why they both ask for it if you set them

CFL and OL don't require accessibility to swipe down for notifications, am i wrong ?

@HeCodes2Much
Copy link
Contributor

HeCodes2Much commented Dec 23, 2022

OL doesnt have the feature and yes OLCF does as the is just a fork with a few extra redesigns and languages

EDIT: ok so that is a bug for mLauncher ill fix that right now

@Npa972
Copy link
Author

Npa972 commented Dec 23, 2022

OL doesnt have the feature and yes OLCF does as the is just a fork with a few extra redesigns and languages

EDIT: ok so that is a bug for mLauncher ill fix that right now

Both has this feature (swip down for notifications) working out of the box.
image

@HeCodes2Much
Copy link
Contributor

HeCodes2Much commented Dec 23, 2022

found the issue and it will be fixed in the next update tomorrow

@HeCodes2Much
Copy link
Contributor

HeCodes2Much commented Dec 23, 2022

@Npa972 i have re pushed the release for 0.3.7 and should now be fixed instead of waiting f-droid didn't already pick it up anyways so :)

@Npa972
Copy link
Author

Npa972 commented Dec 24, 2022

Good news. It look better in french. Thank's for them :)

@HeCodes2Much
Copy link
Contributor

Good news. It look better in french. Thank's for them :)

can this now be closed?

@Npa972
Copy link
Author

Npa972 commented Dec 24, 2022

I remove accessibility action and swipe down for notifications works !
I use now double tap to open an app. That's perfect. for me.

@Npa972
Copy link
Author

Npa972 commented Dec 24, 2022

Good news. It look better in french. Thank's for them :)

can this now be closed?

Yes. But perhaps you will have other asking to improve french translation because it's not perfect. French is not concise and two words in english can be four or five in french. And visually, it's not very nice.

@HeCodes2Much HeCodes2Much self-assigned this Dec 24, 2022
@DroidWorksStudio DroidWorksStudio locked and limited conversation to collaborators Dec 24, 2022
@HeCodes2Much HeCodes2Much converted this issue into discussion #105 Dec 24, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
Good first issue Good for newcomers Look & Feel The look and feel of the application Type: Bug Report Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants