Skip to content
This repository has been archived by the owner on Jun 14, 2022. It is now read-only.

Memory Leak #15

Open
ibm2187 opened this issue Dec 3, 2018 · 3 comments
Open

Memory Leak #15

ibm2187 opened this issue Dec 3, 2018 · 3 comments
Assignees
Labels

Comments

@ibm2187
Copy link

ibm2187 commented Dec 3, 2018

Hey,
Great library, made life easier for me.
but, it has a memory leak when I use Casty.create(this).withMiniController() in my activity

unless I'm implementing the code wrongly?

@koral--
Copy link
Member

koral-- commented Dec 4, 2018

With that amount of info you provided it can be anything.
Please share a minimal sample project which reproduces your issue.

@ibm2187
Copy link
Author

ibm2187 commented Dec 4, 2018

I first used Casty.configure("id") at my Application file
at MainActivity, I initialized casty -> var casty: Casty? = null
then casty = Casty.create(this).withMiniController()
and for the toolbar, I used
override fun onCreateOptionsMenu(menu: Menu?): Boolean {
casty?.addMediaRouteMenuItem(menu!!)
return super.onCreateOptionsMenu(menu)
}

Similarly, I used the same initialization and code for the Post Activity (which is leaking) even without casting any video
here is my Leak Canary:

screenshot_20181204-091728

@ibm2187
Copy link
Author

ibm2187 commented Dec 4, 2018

MiniFragment controller also started leaking after few minutes

screenshot_20181204-095817
screenshot_20181204-095822

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants