Use more clear names for methods changing unit of value. #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example expression 2.px tells nothing about from what to what unit we convert. It's better to use dpToPx name. This name tells us that we convert from dp to pixels. Everything is clear. Int.dp -> pxToDp(Float): Float Int.sp -> spToPx(Float): Float And argument and return type are changed to Float, because more often we use Float, not Int
|
LGTM but there are some conflicts. |
# Conflicts: # timerangepicker/src/main/java/nl/joery/timerangepicker/DefaultClockRenderer.kt # timerangepicker/src/main/java/nl/joery/timerangepicker/TimeRangePicker.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example expression 2.px tells nothing about from what to what unit we convert. It's better to use dpToPx name. This name tells us that we convert from dp to pixels. Everything is clear.
Int.dp -> pxToDp(Float): Float
Int.sp -> spToPx(Float): Float
And argument and return type are changed to Float, because more often we use Float, not Int