Add support for custom clock renderers #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Clock renderers become stateless * Clock renderer of TimeRangePicker can be easily changed to custom * Default implementation of ClockRenderer added
…rer attribute in README.md
|
Sorry for the delayed response, but thank you for your contribution, this is definitely a better implementation :)! |
|
Let me know if you want me to release a new version :) |
|
I'm working on some performance improvements and when I implement them all, I'll let you know about a need to release a new version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a support for custom clock renderers. A clock renderer become stateless (it was connected with the view before).
An user can easily change default clock renderer to preferred one. But the render performance may degrade a lit bit because of virtualization.