Skip to content
This repository has been archived by the owner on Feb 1, 2019. It is now read-only.

Serialize a blob into an existing collation body. #78

Open
jamesray1 opened this issue May 22, 2018 · 13 comments
Open

Serialize a blob into an existing collation body. #78

jamesray1 opened this issue May 22, 2018 · 13 comments
Labels
M4: core Core client code / Rust. P5: some time soon The issue is worth doing soon. Q6: substantial with mentor A moderate task were a mentor is available. Please indicate in the issue who the mentor could be.

Comments

@jamesray1
Copy link
Member

For details, see:

https://github.com/Drops-of-Diamond/diamond_drops/blob/develop/node/src/modules/collation/blob.rs#L195-L202

@jamesray1 jamesray1 added Q6: substantial with mentor A moderate task were a mentor is available. Please indicate in the issue who the mentor could be. M4: core Core client code / Rust. P5: some time soon The issue is worth doing soon. labels May 22, 2018
@jamesray1
Copy link
Member Author

@tcsiwula or @samparsky, would you like to have a go at this?

@timxor
Copy link
Contributor

timxor commented May 22, 2018

Yeah, me pretty please!

@jamesray1
Copy link
Member Author

jamesray1 commented May 22, 2018

Great, let me know if you need any help. Keep a log of your time.

@timxor
Copy link
Contributor

timxor commented May 22, 2018

Sounds good @jamesray1 . FYI, I was just pulling/merging in your latest changes from your develop branch. Very big!

[~/Desktop/diamond_drops]$git pull upstream develop
........
[~/Desktop/diamond_drops]$git push
Counting objects: 1072, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (569/569), done.
Writing objects: 100% (1072/1072), 52.27 MiB | 731.00 KiB/s, done.
Total 1072 (delta 414), reused 1029 (delta 378)
remote: Resolving deltas: 100% (414/414), completed with 31 local objects.
remote: warning: GH001: Large files detected. You may want to try Git Large File Storage - https://git-lfs.github.com.
remote: warning: See http://git.io/iEPt8g for more information.
remote: warning: File rls/debug/deps/libsyntex_syntax-189bf668f45d362c.rlib is 53.72 MB; this is larger than GitHub's recommended maximum file size of 50.00 MB
To https://github.com/tcsiwula/diamond_drops.git
   82826ed..3b8325b  develop -> develop

@jamesray1
Copy link
Member Author

jamesray1 commented May 23, 2018

Yeah I saw that as well a while back, although I don't know why rls/debug/deps/libsyntex_syntax-189bf668f45d362c.rlib is so big, and I'm not sure if we need it in the repo. I'll add it to .gitignore.

@jamesray1
Copy link
Member Author

Ah rls/debug/deps/libsyntex_syntax-189bf668f45d362c.rlib is already in .gitignore (included as part of /rls/), so I'm not sure why you got that error.

@jamesray1
Copy link
Member Author

Is your local .gitignore file the same as the upstream one?

@timxor
Copy link
Contributor

timxor commented May 24, 2018

I have this one:

# Generated by Cargo
# will have compiled files and executables
/target/
/cli/target/
/env/target/
/node/target/

# These are backup files generated by rustfmt
**/*.rs.bk

# Remove Cargo.lock from gitignore if creating an executable, leave it for libraries
# More information here https://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html
Cargo.lock

# Generated by MML via build.rs. ml.svg should stay, it's XML, so the text in the file
# that shows in the GitHub and Git diff won't actually display like that.
diagrams/ml.dot

# Added from the rls extension in VS Code
/rls/

# Generated via Clap CLI
output.log

I think that directories have no / at the start of them, last I checked a few days ago for another project.

So maybe (mAyBe!) this

# Added from the rls extension in VS Code
/rls/

should be just this

rls/

@jamesray1
Copy link
Member Author

You're right, otherwise cd env, for example, wouldn't work. You'd use cd rls or cd ./rls

@jamesray1
Copy link
Member Author

Please give me your Github no-reply email address for https://blog.github.com/2018-01-29-commit-together-with-co-authors/.

@jamesray1
Copy link
Member Author

Changed gitignore with #81.

@jamesray1
Copy link
Member Author

We should look into using protobuf, it seems like a better alternative: https://ethresear.ch/t/blob-serialisation/1705/23?u=jamesray1.

@timxor
Copy link
Contributor

timxor commented May 30, 2018

I have heard of protobuf, seems legit. Will look into more. I read rust/cargo also has a good profiler tool that can analyze memory usage.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
M4: core Core client code / Rust. P5: some time soon The issue is worth doing soon. Q6: substantial with mentor A moderate task were a mentor is available. Please indicate in the issue who the mentor could be.
Projects
None yet
Development

No branches or pull requests

2 participants