Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too many changes without any difference #75

Closed
nisiode opened this issue Apr 14, 2020 · 4 comments
Closed

Too many changes without any difference #75

nisiode opened this issue Apr 14, 2020 · 4 comments

Comments

@nisiode
Copy link

nisiode commented Apr 14, 2020

https://github.com/iobroker-community-adapters/ioBroker.discovergy/blob/21a4f4f33cd653e271a158f095f3358ed4c1dd83/main.js#L139

Describe the bug
As developer of ioBroker.iogo, I see huge amount of object changes being logged without any changes.

Expected behavior
Change objects only if there are real changes being made to the existing object.

@DutchmanNL
Copy link
Collaborator

Agree I will change that to an initialization Routine only thank you !

@nisiode
Copy link
Author

nisiode commented Apr 16, 2020

thank you for reducing my billing

@DutchmanNL
Copy link
Collaborator

i realized if you combine this with SourceAnalytix your ioBroker gets into an complete loop so fix is on its way :)

@DutchmanNL
Copy link
Collaborator

DutchmanNL commented Apr 17, 2020

should be fixed in 0.5.1

https://github.com/iobroker-community-adapters/ioBroker.discovergy/blob/master/main.js#L237-L274

I compare now every object type before executing a setstate, so at initialization you always have a setObject ( which make sense ) but later during runtime only if attributes are not equal to value stored in memory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants