Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin tab link hardcoded to http #159

Open
r748 opened this issue Apr 15, 2023 · 5 comments
Open

Admin tab link hardcoded to http #159

r748 opened this issue Apr 15, 2023 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@r748
Copy link

r748 commented Apr 15, 2023

The admin tab link is hardcoded to use http (io-package.json => http://%ESPHomeDashboardIP%:%ESPHomeDashboardPort%). This leads to the issue, that the ESPHome-Dashboard is not displayed in the iFrame when running ioBroker under https. Loading the dashboard via the direct URL (e.g. https://ESPHomeDashboardIP:6052/) works as expected.

Please add a config option to specify if the %ESPHomeDashboardIP% is http or https. Thanks!

@r748 r748 added the bug Something isn't working label Apr 15, 2023
@DutchmanNL
Copy link
Contributor

hmm the problem is I cannot make this setting variable

@Apollon77

Can you please assist here ? How can we deal in io-package with an attribute like the URL from http to https ?
Would it be sufficient to just enter the link without http://. or https:// in front of it ?

@DutchmanNL
Copy link
Contributor

@Apollon77 or @UncleSamSwiss ? :)

@UncleSamSwiss
Copy link
Contributor

@DutchmanNL Why is it not possible to make this setting variable? IP and port seem to be variable, too. Can't you just add another setting for the schema (http or https)?

@Apollon77
Copy link
Contributor

@DutchmanNL naja die erste Frage ist ja um was es genau geht. Also: ist dein extra ui überhaupt über https erreichbar oder nicht? Wenn ja dann bräuchte man etwas wie „adminprotocol“ als variable was ersetzt wird. Wen nicht dann sind wir bei dem Thema was wir mehrfach besprochen hatten und das heißt „Admin muss einen Reverse Proxy haben um solche uis mit „seinem ssl“ durchzuproxien.

Also wat isses? ;-)

@DutchmanNL
Copy link
Contributor

Also wat isses? ;-)

Soweit mir bekannt kam Esphome kein https und hat selber auch keine certificate @r748 bitte korrigieren wen ich falsch liege

Ergo das wird Dan die größere Proxy Geschichte @Apollon77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants