Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global variable 'Old_SW_VegProd' unused -- do we still need it? #92

Closed
dschlaep opened this issue Nov 29, 2017 · 3 comments
Closed

Global variable 'Old_SW_VegProd' unused -- do we still need it? #92

dschlaep opened this issue Nov 29, 2017 · 3 comments
Labels
Milestone

Comments

@dschlaep
Copy link
Member

  • Global variable 'Old_SW_VegProd' was introduced by commit 12a99e8 (three years ago).

  • Function SW_VPD_read() sets it as copy of SW_VegProd.

  • It is not used by any code by SOILWAT2. Does this variable have any (hidden) need to exist? If not, can we delete it? @ashishtiwari2006 @BrendenBe1 @kpalmqui

@dschlaep dschlaep added this to the Clean code milestone Nov 29, 2017
@BrendenBe1
Copy link
Contributor

It seems like it serves no purpose. I commented it out and ran STEPWAT and SOILWAT standalone and noticed no difference in output and no errors occured.

@kpalmqui
Copy link
Member

kpalmqui commented Dec 4, 2017

I concur - we can delete it.

@dschlaep
Copy link
Member Author

dschlaep commented Dec 5, 2017

Thanks for checking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants