Select MarqueeLabel import based on build system #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbpowell
commented
May 13, 2017
| @@ -310,6 +326,7 @@ | |||
| INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks"; | |||
| IPHONEOS_DEPLOYMENT_TARGET = 9.3; | |||
| LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks"; | |||
| OTHER_SWIFT_FLAGS = "-DCARTHAGE_CONFIG"; | |||
There was a problem hiding this comment.
Note that the important project file change is here, I somewhat inadvertently included the change for importing the frameworks (was just getting it to build).
|
This works because @Dschee created an additional Xcode project in the repo for the Carthage framework build. There's no impact to the Example project which still uses @Daltron's .xcworkspace, to which I did not add the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a custom Swift complier flag, allowing a if/else statement to pick
import MarqueeLabelvsimport MarqueeLabelSwiftto work around Cocoapods/Carthage compatibility issues.See cbpowell/MarqueeLabel#181.