Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix qoi thumbnail selection #283

Closed
mfs12 opened this issue Apr 4, 2023 · 4 comments
Closed

Fix qoi thumbnail selection #283

mfs12 opened this issue Apr 4, 2023 · 4 comments
Assignees
@mfs12
Labels
bug
Milestone
3.5

Comments

@mfs12
Copy link
Contributor

mfs12 commented Apr 4, 2023

Description

Description

Thumbnail selection doesn't work in certain situations.

https://forum.duet3d.com/topic/31919/no-qoi-thumbnail-displayed-superslicer-2-5-59

Versions

  • PD 3.4.1

Process

  • refer to forum

Experienced Result

no thumbnail is displayed

Expected Result

thumbnail is displayed
@mfs12 mfs12 added the bug label Apr 4, 2023
@mfs12 mfs12 added this to the 3.5 milestone Apr 4, 2023
@mfs12 mfs12 self-assigned this Apr 4, 2023
@dc42
Copy link
Collaborator

dc42 commented Apr 4, 2023

This may be a RRF issue, caused by the first thumbnail being so long that RRF doesn't look beyond it. I am running some tests.

@dc42
Copy link
Collaborator

dc42 commented Apr 4, 2023

Confirmed, this was a RRF issue. On my test file with 300x300 followed by 160x160 thumbnails, RRF only reported the first one. I have increased the amount of the file we scan. Now the second one is also reported and PanelDue displays it.

@dc42 dc42 closed this as completed Apr 4, 2023
@mfs12
Copy link
Contributor Author

mfs12 commented Apr 5, 2023 •
edited

@dc42 did you test it with the files from marvineer?

@dc42
Copy link
Collaborator

dc42 commented Apr 5, 2023

No, I reproduced it with a file I generated form PrusaSlicer, and tested the fix on the same file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mfs12 mfs12

Labels
bug
Projects
None yet
Milestone
3.5
Development

No branches or pull requests
2 participants
@mfs12 @dc42