Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix displaying of title and buttons in different modes #294

Closed
mfs12 opened this issue Apr 21, 2023 · 1 comment · Fixed by #293
Closed

Fix displaying of title and buttons in different modes #294

mfs12 opened this issue Apr 21, 2023 · 1 comment · Fixed by #293
Assignees
Labels
Milestone

Comments

@mfs12
Copy link
Contributor

mfs12 commented Apr 21, 2023

Description

  • The message box title displays the R value from the previous M291 command (even if it was in a different macro). Verified with S = 0,1,2 but didn't test on other modes.
  • If S = 1, there is no CLOSE button, but there is window close button ("X" in the corner). - reported by @Exerqtor
  • If S=2, there is no OK button, but there is window close button ("X" in the corner). If T=0, the X will close the window but does not unblock execution. An INFO message is added to the eventlog saying "M292: cancelled=false"
@mfs12 mfs12 added the bug label Apr 21, 2023
@mfs12 mfs12 self-assigned this Apr 21, 2023
@mfs12
Copy link
Contributor Author

mfs12 commented Apr 21, 2023

#293

@mfs12 mfs12 added this to the 3.5 milestone Apr 21, 2023
@mfs12 mfs12 linked a pull request Apr 21, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant