Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple thumbnail images in job file not handled properly #300

Closed
dc42 opened this issue May 9, 2023 · 0 comments · Fixed by #302
Closed

Multiple thumbnail images in job file not handled properly #300

dc42 opened this issue May 9, 2023 · 0 comments · Fixed by #302
Assignees
Labels
Milestone

Comments

@dc42
Copy link
Collaborator

dc42 commented May 9, 2023

A file may contain multiple thumbnails, but PD only stores one set of details in variable 'thumbnail', and when PD receives thumbnail data in the M36 response it overwrites any previous details. So it only stores the last details received, and they may not be suitable for PD. See https://forum.duet3d.com/topic/31840/how-to-get-thumbnails-on-paneldue/16?_=1683480130659.

A fix would be for PD to parse new thumbnail data into a temporary variable, then when parsing it is complete, if it is suitable for PD and better than the values (if any) in 'thumbnail', copy it into 'thumbnail'.

@dc42 dc42 added the bug label May 9, 2023
@mfs12 mfs12 added this to the 3.5 milestone May 10, 2023
@mfs12 mfs12 self-assigned this May 10, 2023
@mfs12 mfs12 linked a pull request May 21, 2023 that will close this issue
@mfs12 mfs12 closed this as completed May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment