Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abort command in load.g or unload.g filament macros changes filament, as it was correctly loaded/unloaded #437

Closed
michele-bertoni opened this issue Oct 16, 2020 · 9 comments
Assignees
Labels
bug Bug that has been reproduced

Comments

@michele-bertoni
Copy link

If an abort command is called when loading or unloading a filament (both with M701 or M702 and with the Duet Web Control), Duet will then change the filament name of the associated tool, as the filament was correctly loaded or unloaded. A very strange behavior happens, instead, when an error (such as G0/G1: insufficient axes homed) is thrown: in this case the filament name is not changed. The problem happens both if the abort command is inside load.g/unload.g file and if it is inside a nested macro called by load.g/unload.g.

@zombiRon
Copy link

zombiRon commented Oct 16, 2020

forget abort, you can't even change filament without it resetting

@michele-bertoni
Copy link
Author

forget abort, you can't even change filament without it resetting

You mean the error present in latest beta release? It has already been fixed for the next beta release

@zombiRon
Copy link

Yes, so how are you testing this without it resetting?

@michele-bertoni
Copy link
Author

Yes, so how are you testing this without it resetting?

I'm using latest working release and, since I haven't found anyone reporting this bug, I assumed that it wasn't fixed yet

@zombiRon
Copy link

you're running 3.1.1?

@michele-bertoni
Copy link
Author

Yes, 3.1.1, last stable release

@michele-bertoni
Copy link
Author

I found out that if the tool is deselected (with T-1) at the time the load/unload macro ends, the filament won't change its state. So, if you do T-1 before calling abort, it works fine.

@skezo
Copy link

skezo commented Apr 15, 2023

This issue is present in release 3.4.5.
If you run abort "Cancel load" inside /filaments/<filament>/load.g or inside a submacro of load.g the Filament will change state.

This also happens if your macro contains M291 command with S3. If the user presses "Cancel" the filament will change to the new state.

EDIT
Added some more info here: https://forum.duet3d.com/topic/32139/how-to-cancel-loading-unloading-of-filament

@T3P3 T3P3 assigned dc42 May 4, 2023
@T3P3 T3P3 added the bug Bug that has been reproduced label May 4, 2023
@T3P3 T3P3 modified the milestones: 3.5.0-beta.4, 3.4.6 May 4, 2023
@T3P3 T3P3 removed this from the 3.4.6 milestone Jul 19, 2023
@T3P3
Copy link
Contributor

T3P3 commented Jul 19, 2023

Closed as M99 is the correct approach - see the forum thread.

abort commands are not supported at this point in system macros.

@T3P3 T3P3 closed this as completed Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug that has been reproduced
Projects
None yet
Development

No branches or pull requests

5 participants