Skip to content
This repository has been archived by the owner on Oct 30, 2023. It is now read-only.

Add logic to remove v from inputs #5

Closed
duffney opened this issue Feb 1, 2023 · 0 comments
Closed

Add logic to remove v from inputs #5

duffney opened this issue Feb 1, 2023 · 0 comments

Comments

@duffney
Copy link
Owner

duffney commented Feb 1, 2023

Adding a v in front of the version number is a common mistake made by people using the action. To improve the user experience add logic that handles the additional v by checking if a v exists within the version number and removing it before passing to the URL to download.

Example: Allow this to work

    - name: Setup Notation with azure-kv plugin
      uses: Duffney/setup-notation@v0.12.0
      with:
        version: v1.0.0-rc.1
        key_name: ${{ inputs.certName }}
        certificate_key_id: ${{ steps.kid.outputs.SIGN_CERT_KEY_ID }}
        plugin_name: notation-azure-kv
        plugin_version: v0.5.0-rc.1
@duffney duffney closed this as not planned Won't fix, can't repro, duplicate, stale Feb 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant