Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default meta key #34

Merged
merged 12 commits into from Jul 7, 2022
Merged

Default meta key #34

merged 12 commits into from Jul 7, 2022

Conversation

Dunklas
Copy link
Owner

@Dunklas Dunklas commented Jul 7, 2022 •
edited

Add support for --meta-key argument. The value of each --meta-key argument will be set as a key in meta property.
Additionally:

  • Changed type for meta from Value to Map<String, Value>, which enforces it to be a json object (where each key can have a value with arbitrary json)
  • Enable preserve_order feature in serde_json, which will preserve order to the properties in meta object
    • Previously those would be sorted alphabetically

Fixed #33

@Dunklas Dunklas marked this pull request as ready for review July 7, 2022 04:34
@Dunklas Dunklas merged commit 94421bc into main Jul 7, 2022
@Dunklas Dunklas deleted the default-meta-key branch July 7, 2022 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide default meta
1 participant
@Dunklas