Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Music Events in chinese2.c (Crystal Maze) #45

Open
slavexe opened this issue May 28, 2022 · 2 comments
Open

Missing Music Events in chinese2.c (Crystal Maze) #45

slavexe opened this issue May 28, 2022 · 2 comments
Labels
enhancement New feature or request help-wanted

Comments

@slavexe
Copy link

slavexe commented May 28, 2022

I noticed that most music events from chinese2.c are missing in the music event data dump. This script in particular appears to be using an extra function called func_15 to play music events rather than directly calling AUDIO::TRIGGER_MUSIC_EVENT. For example: func_15("CHN2_STOP_TRACK", 0, func_173()); There may be other scripts that do this, but this is the only one I have found so far.

@DurtyFree
Copy link
Owner

Interesting, but I guess its hard to really track down these and keeping track of them. As of right now its really just reading all uses of the related natives.

Missing things like this occur in many other dumps too as they often use functions and input the string we want as a arg. I think the only way to efficiently dump these would be some logical way of parsing the script and really understanding whats going on. Something I might work on in the future.
Until then I will keep this open

If some one else has a smart idea of automatically tracking such cases, feel free to discuss here!

@DurtyFree DurtyFree added enhancement New feature or request help-wanted labels May 28, 2022
@slavexe
Copy link
Author

slavexe commented May 29, 2022

Yeah I can't think of a good way of fixing this, but I also found exile1.c handles music events in this way too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help-wanted
Projects
None yet
Development

No branches or pull requests

2 participants