GPLv2 license

[cvium]

I can see that you have chosen the GPLv2 license, but that you're also pulling in an Apache 2.0 licensed lib (https://github.com/launchbadge/sqlx) (EDIT: Dual licensed, so ignore).

Unfortunately, to my limited knowledge (and research), those licenses are not compatible and you may, in fact, not distribute the final product under the GPLv2 license.

Have you considered other licenses? GPLv3 is compatible with Apache, but may also be more restrictive than GPLv2.

Another thing is that your web UI seems to be licensed under GPLv2 as well and if you ever plan on using the web UI in a web wrapper for iOS or other stores (smart TVs etc.), you may run into issues. The iOS app store is for instance not compatible with GPL at all.

[vgarleanu]

It looks like sqlx is actually dual licensed with MIT or Apache 2.0. I think we're fine here, but I'm not too sure.

[vgarleanu]

Another thing is that your web UI seems to be licensed under GPLv2 as well and if you ever plan on using the web UI in a web wrapper for iOS or other stores (smart TVs etc.), you may run into issues. The iOS app store is for instance not compatible with GPL at all.

We're not planning on using the web ui in a wrapper for ios, we'll be building native apps for those with react native. We'll have to rethink the licensing for those tho.

[cvium]

It looks like sqlx is actually dual licensed with MIT or Apache 2.0. I think we're fine here, but I'm not too sure.

I missed that. I only clicked the "View license" button 😄 That particular lib should be fine then. I do, however, still think that GPLv2 might be limiting you in the long run. I'm not familiar with the Rust lib landscape though, but in Jellyfin we do use a bunch of Apache 2.0 libs.

[vgarleanu]

What license do you recommend?

[cvium]

I'm not too familiar with licenses, I license my personal projects under MIT. I am only speaking from experience with GPLv2. As mentioned, GPLv3 is compatible with MIT, BSD and Apache 2.0 (and more), but not everyone likes GPLv3.

It depends on what you want to achieve with the license. Maybe https://choosealicense.com/ can guide you a bit? Keep in mind that if you do re-license, you will have to ask permission from contributors.

[vgarleanu]

Noted. Thanks for the tip!

[cvium]

I did a second pass and web-vitals (used in ui) is indeed Apache 2.0 licensed. Just a heads-up :) And I thought about licensing choice a bit and if you distribute ffmpeg with Dim you're likely forced to use GPLv3 in the end but IANAL.

[vgarleanu]

@eraychumak